Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

• [ENH] Support regex for local Chroma #4527 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Add Regex Filtering Support for Local Chroma

This PR introduces support for regular expression (regex) filtering in local Chroma collections, enabling users to perform regex-based document retrieval. It updates both backend SQLite integration (via Rust) to support the REGEXP operator, modifies configuration to enable SQLite regex, and provides corresponding unit tests to verify correct functionality.

Key Changes:
• Implements REGEXP-based filtering in local Chroma by updating the query logic in rust/segment/src/sqlite_metadata.rs.
• Enables SQLite's REGEXP operator in the config initialization (rust/sqlite/src/config.rs) and specifies the required sqlx feature in rust/sqlite/Cargo.toml.
• Updates dependencies and lockfile to support regex.
• Adds unit tests in chromadb/test/property/test_filtering.py to verify correct regex behavior in document filtering.

Affected Areas:
• Rust SQLite backend query logic
• SQLite database configuration and feature flags
• Python property-based/document filtering tests
• Cargo.toml and Cargo.lock dependency management

This summary was automatically generated by @propel-code-bot

Can you add a basic test for this?

Please add basic tests at the python side, also does js client support this?

Yes this will be a scan on the document index

Please add basic tests at the python side, also does js client support this?

JS client support will be added in the new client impl

Merge activity

• May 27, 9:54 PM UTC: @Sicheng-Pan merged this pull request with Graphite.